feat(tls,ws): move MaybeTlsStream to tls#516
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the MaybeTlsStream type from compio-ws to compio-tls to improve code organization. The implementation now supports both native-tls and rustls features (previously only rustls), with the old location deprecated and re-exported for backward compatibility.
Key changes:
- Relocated
MaybeTlsStreamand its trait implementations to a newmaybe.rsmodule incompio-tls - Expanded feature flag support from
rustls-only tonative-tlsORrustls - Version bumps for affected packages (
compio-tls: 0.7.1 → 0.7.2,compio-ws: 0.1.0 → 0.1.1)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-ws/src/stream.rs | Replaces implementation with deprecation notice and re-export from compio-tls |
| compio-ws/src/rustls.rs | Updates import path to use MaybeTlsStream from compio-tls instead of local module |
| compio-ws/Cargo.toml | Bumps version to 0.1.1 |
| compio-tls/src/maybe.rs | Adds new MaybeTlsStream implementation with expanded feature support for both TLS backends |
| compio-tls/src/lib.rs | Exports the new maybe module |
| compio-tls/Cargo.toml | Bumps version to 0.7.2 |
| Cargo.toml | Updates workspace dependency version for compio-tls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@George-Miao Ping? Thanks. |
Member
Author
|
I think I'll just add some breaking changes in the next PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually I don't want to introduce breaking changes to
compio-ws, butMaybeTlsStreamwas mistakenly made public, so we have to keep the enum public. I think we should make the enum variants private in the next major version.